Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[➕ Feature]: save configuration mapping, extraction, correlation, workflow and other to repository #3010

Open
00041275 opened this issue Jan 12, 2025 · 6 comments
Labels
Feature A new feature

Comments

@00041275
Copy link
Contributor

I'm concerned that keep only works with data at the moment. From a user experience perspective, pressing the delete button is too easy. This thought makes me scared. The more people in the team use it, the more likely it is to break someone's settings. Any thoughts on saving settings? Since you are into the git workflow concept, maybe it makes sense to consider saving settings in a repository, like backstage.io does?
https://backstage.io/docs/features/software-catalog/

@dosubot dosubot bot added Feature A new feature labels Jan 12, 2025
@00041275 00041275 changed the title [➕ Feature]: save configuration mapping, extraction, correlation and other to repository [➕ Feature]: save configuration mapping, extraction, correlation, workflow and other to repository Jan 12, 2025
@shahargl
Copy link
Member

We support auto provisions of workflows, providers and mapping through env variables. We plan to extend it.

See https://docs.keephq.dev/deployment/provision/overview

@00041275
Copy link
Contributor Author

But, why I need to restart server every time for use provision? What if I have problem with JSON. I don't want to have trouble.

We support auto provisions of workflows, providers and mapping through env variables. We plan to extend it.

See https://docs.keephq.dev/deployment/provision/overview

@00041275
Copy link
Contributor Author

And env variables not readable. Why env provision can't use link to file/files/folder, secret manager? And why it's work for restart server?

image

@shahargl
Copy link
Member

@00041275 is just matter of priority, we will eventually add it. would you up to contribute it?

@00041275
Copy link
Contributor Author

@00041275 is just matter of priority, we will eventually add it. would you up to contribute it?

I try

@00041275
Copy link
Contributor Author

00041275 commented Jan 16, 2025

@shahargl

what about next:

  1. add cron "update_provision" in https://github.com/keephq/keep/blob/main/keep/api/arq_worker.py
  2. then call secret store for PROVISION...(dashboard, workflow, deduplication) data and update ENV
    2.1) may be add condition and logic for workflow directory (to look env)
  3. then call function provision_resources() in https://github.com/keephq/keep/blob/main/keep/api/config.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new feature
Projects
None yet
Development

No branches or pull requests

2 participants