Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[📃 Docs]: sound notification mechanism work #3018

Open
00041275 opened this issue Jan 14, 2025 · 2 comments
Open

[📃 Docs]: sound notification mechanism work #3018

00041275 opened this issue Jan 14, 2025 · 2 comments
Labels
Documentation Improvements or additions to documentation Question Further information is requested

Comments

@00041275
Copy link
Contributor

How does the sound notification mechanism work? Who will hear it? Is it correct to launch a notification for everyone who has entered keep, maybe it is worth launching it from the dashboards with set audiofile to play? Is there a poll for new alerts and its frequency or is it expected that the webhook will deliver information and the sound will go? Why I can't change the sound? 1.5 minutes of audio is something cool at first, but disgusting after 5 minutes?
If I was heard from the dashboards by sounds, then I would like to add an interval polling function. The current dashboards are more like reports than operational dashboards.

image

@00041275 00041275 added the Documentation Improvements or additions to documentation label Jan 14, 2025
Copy link

dosubot bot commented Jan 14, 2025

The sound notification mechanism in Keep is not detailed in the available information, so I can't provide specifics on how it works or who will hear it. However, I can confirm that Keep uses a polling mechanism for new alerts. This is implemented using a custom hook useAlertPolling, which utilizes a WebSocket connection to listen for incoming data on the "poll-alerts" event. The polling occurs every 10 seconds [1].

Regarding customization of sound notifications, such as changing the audio file or its duration, there is no available information on whether this is possible. It seems that the current setup might not allow for such changes, which could explain the fixed 1.5-minute audio duration you mentioned.

If you are looking for more operational dashboards with sound notifications based on specific alert conditions, it might be worth exploring if there are any configuration options within the dashboard settings, although this is not detailed in the current information.

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other

@dosubot dosubot bot added the Question Further information is requested label Jan 14, 2025
@shahargl
Copy link
Member

@00041275 quite a lot of questions ^^.

I'll try to answer -

How does the sound notification mechanism work?

  1. either set the whole preset as noisy and then if one alert firing and match this preset it would sound
  2. set alert with isNoisy=true and then the preset will make noise

Who will hear it?

everyone who opens Keep and the noisy preset in their navbar (you can filter it out)

Is it correct to launch a notification for everyone who has entered keep, maybe it is worth launching it from the dashboards with set audiofile to play?

can you elaborate on that? what's dashboards in your context? presets?

Is there a poll for new alerts and its frequency or is it expected that the webhook will deliver information and the sound will go?

with websocket enabled, new alerts are kinda "real-time" - the server will send the browser a "message" that a new alert arrived and it should re-poll

Why I can't change the sound? 1.5 minutes of audio is something cool at first, but disgusting after 5 minutes?

you can override alert.mp3 and put there whatever you want. because Keep is open source, we couldn't add licensed music. we can add a way to override the alert.mp3 from settings or smth

If I was heard from the dashboards by sounds, then I would like to add an interval polling function. The current dashboards are more like reports than operational dashboards.

can you elaborate on that too? wdym by "current dashboards are more like reports than operational dashboards."? what would make them operational? and wdym by dashboards? the presets?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants