Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcuts don't behave as expected #184

Open
axelsimon opened this issue Nov 28, 2024 · 12 comments
Open

Keyboard shortcuts don't behave as expected #184

axelsimon opened this issue Nov 28, 2024 · 12 comments
Labels
needinfo Requesting information from the reporter

Comments

@axelsimon
Copy link

axelsimon commented Nov 28, 2024

Hi and thanks for your work on this super helpful extension!

I have a couple issues with Quickmove's keyboard shortcuts.

  • The "open menu" shortcut, ctrl+shift+N does nothing. Before I disabled it, CardBook would catch it and open its "new contact" view.
  • The "move" shortcut, ctrl+shift+M does not open Quickmove menu but moves the currently focused email to the last selected Quickmove target directory (with no feedback or warning, might I add).

This is on Thunderbird 128.5.0esr (Flatpak).

Sorry if these have been reported, I checked and they seem different to me from what is already in the issue tracker :)

@axelsimon axelsimon changed the title Keyboard shortcut don't behave as expected Keyboard shortcuts don't behave as expected Nov 28, 2024
@kewisch
Copy link
Owner

kewisch commented Nov 30, 2024

The only remaining shortcut should be Ctrl+Shift+N. If this one is taken by CardBook, you have to change it in your Add-ons Shortcut Manager. Go to your add-ons list, click on the cog icon, manage extension shortcuts, and pick a new one that works for you and isn't taken by Thunderbird or another add-on. You can define a shortcut for each action there.

Where did you get Ctrl+Shift+M, did I forget to update documentation somewhere, or muscle memory from before?

@kewisch kewisch added the needinfo Requesting information from the reporter label Nov 30, 2024
@axelsimon
Copy link
Author

Can't remember where the Ctrl+Shift+M shortcut came from, i think it was suggested at some point?
I also could have come up with it.

In any case, the weirdest part is that the menu doesn't come up at all. Clicking it works, so I know it does work, but the shortcut does nothing.

Right now, CardBook is uninstalled, so it shouldn't create any issues with QuickMove.

@github-actions github-actions bot removed the needinfo Requesting information from the reporter label Dec 4, 2024
@kewisch
Copy link
Owner

kewisch commented Dec 4, 2024

Yes Ctrl+Shift+M was an intermediate suggestion, I unfortunately had to change it due to Windows/Linux differences.

What menu do you mean? Here is what it looks like for me:

Hamburger/thee bars menu -> Addons brings you here:

image

Cog Icon > Manage Extension Shortcut brings you here:

image

And then you say the shortcut you define there does not actually open the menu? Can you double check that it does not conflict with anything else from Thunderbird or an add-on? Sometimes it doesn't say.

@kewisch kewisch added the needinfo Requesting information from the reporter label Dec 7, 2024
@CharlesDelorme
Copy link
Contributor

Whoa ! This last message would benefit to be more explicit in the documentation. I was looking for the "manage extension shortcuts" panel within QFM configuration (and obviously never found it) and I really never took time to read the addon menu up to the last item, my bad…

@github-actions github-actions bot removed the needinfo Requesting information from the reporter label Dec 14, 2024
@CharlesDelorme
Copy link
Contributor

BTW in 3.0.0 you still have a screen cap with a mac ctrl-shift-M. Since I am a little bit confused as such key combination is only for mac and ctrl-shif-N for win/linux this screen cap may confused others :-)

image

@CharlesDelorme
Copy link
Contributor

Here is the screen cap in french under windows
image

@kewisch
Copy link
Owner

kewisch commented Dec 15, 2024

Do you have a suggestion how to improve the docs? I've updated the README with a bit more info and updated the screenshots. In the onboarding I otherwise link to https://support.mozilla.org/en-US/kb/manage-extension-shortcuts-firefox which admittedly is a Firefox article, but it works the same way in Thunderbird.

@CharlesDelorme by the way, would you be willing to update the French translation at https://hosted.weblate.org/projects/quick-folder-move/main/fr/ ? A few strings are translated from a prior contributor, but it hasn't been updated in a while. I unfortunately don't speak French.

@CharlesDelorme
Copy link
Contributor

Concerning the extension shortcuts I must admit I just didn't read everything, so maybe the doc is ok

And I will have a look a the translation

@CharlesDelorme
Copy link
Contributor

I gave a try to translations. I only missed one for which I don't now where it might be used ("Please enable the 'Tags' folder view to go to tag folders")

@kewisch
Copy link
Owner

kewisch commented Dec 17, 2024

See #182

@axelsimon
Copy link
Author

What menu do you mean?

I mean the Quickmove menu:
Screenshot From 2024-12-18 14-57-20

But looking at the add-on shortcuts options, I'm starting to think there is no shortcut to just bring up the Quickmove menu anymore, only to trigger QM actions?

@kewisch
Copy link
Owner

kewisch commented Dec 19, 2024

No, the shortcuts remain for opening the popup, they simply pre-select the action. Otherwise there would be no way to know which folder to move or go to.

@axelsimon Do you have a shortcut assigned to Move, and if so which is it?

@kewisch kewisch added the needinfo Requesting information from the reporter label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needinfo Requesting information from the reporter
Projects
None yet
Development

No branches or pull requests

3 participants