Patternfly topology for Kiali graph

[jshaughn]

One goal of OpenShift plugins is to offer consistent UX (user experience) with both native console and other plugins. This consistent UX may end up being an acceptance criteria for acceptance as an official plugin for RHOS (and not just a community plugin, or tech preview). The Kiali graph offer a very different look and feel from other topology views in OS, such as dev console, netobserv, and others. If feasible it could be a beneficial for Kiali to offer a PF topology option.

POC / Initial Impl

• Research PFTopology as a POC (Summary Here)
• Initial PFT Graph #100
• add mechanism to show/hide PFT graph option (done as part of OSSMC-100)

Things needed for OSSMC GA

• Adjust graph-tour in a few places the text needs an update for PF graph #202
• [PFT graph] Solve problem with node badging kiali#6370
• Add legend to the PF topology #183
• Focus selector support in PF graph #203
• this is a placeholder for GA review issues (no issues blocking OSSMC GA)

Improvements (removing code customizations and contributions to PF)

• Remove customizations done in PF edges #223
• Remove customizations done in PF nodes #224
• Remove customizations done in PF groups #225
• Hide tags when details level is low, except when hovering on the edge patternfly/react-topology#122
• Add support to DefaultGroup to support rectangular shape patternfly/react-topology#113

Additional Issues
Things that are still a delta between the Cy graph and the PF graph impls. Some may not be doable or may require a contribution to PFT. Note that even some of the earlier work may be better supported with a PFT contribution.

Must Have for Cytoscape deprecation (2.0):

• support for rectangular boxing (PFT5 see Add support to DefaultGroup to support rectangular shape patternfly/react-topology#113)
• solution for node label overlap (PFT5 see DefaultGroupExpanded doesn't allow separate padding setting for top, left, bottom, and right. patternfly/react-topology#126)
• support for wizard context menu items (PFT5, see Topology - withContextMenu support for Promise patternfly/react-topology#15)
• support for scaled-label-on-hover (I think this may be coming in PFT 5.4)
• support for group label-on-hover (I think this may be coming in PFT 5.4)
• support for node "focus"
• at least one acceptable layout option
• Cypress tests for PatternFly Graph kiali#7799
• Make PFT Graph the default kiali#7785
• PF node graph side panel snaps back to target node on refresh kiali#7770
• [pft graph] solve bendpoint issues with parallel edges kiali#7780
• [pft graph] Fix issue with bookmarked find/hide not being evaluated kiali#7781
• [pft graph] remove node kebab menus in favor of secondary-click contextual menu kiali#7803
• [pft graph] add back dynamic context menu actions kiali#7807
• Enable rank feature in the patternfly graph kiali#7831

Want:

• Graph toolbar: Replace disabled with active style kiali#7816
• RFE: Selection-based zoom patternfly/react-topology#222

Nice to Have:

• better animation styling
• support "box-specific" layout options (i.e. always use Dagre for namespace boxes)
• support vertical ControlBar (in-graph menu)
• Spacing problem in layouts other than Dagre  patternfly/react-topology#131 (more layouts supporting groups)

Optional PFT-specific features we may want to add

• Collapsible boxes (groups)

[jshaughn]

Closing as all Needs and 1 want have been satisfied! The remaining want is waiting on a PFT RFE. The nice to haves can be revisited as the need arises.