You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is kinda a chimeric issue. Related to my #68, block_network should also have the option to set allowed_hosts via vcr_config, imho.
But then I thought "aren't the ignore_localhost and ignore_hosts parameters from the vcr_config basically the same as allowed_hosts?". VCRpy is adding localhost, 0.0.0.0 and 127.0.0.1 if ignore_localhostis truthy, and also adds ignore_hosts to the set.
I think it would make for a more seamless integration with vcrpy if allowed_hosts is also using ignore_localhost and ignore_hosts from the vcr_config to construct the list while retaining backwards compatibility :-)
The text was updated successfully, but these errors were encountered:
This is kinda a chimeric issue. Related to my #68,
block_network
should also have the option to setallowed_hosts
via vcr_config, imho.But then I thought "aren't the
ignore_localhost
andignore_hosts
parameters from the vcr_config basically the same as allowed_hosts?". VCRpy is adding localhost, 0.0.0.0 and 127.0.0.1 ifignore_localhost
is truthy, and also addsignore_hosts
to the set.I think it would make for a more seamless integration with vcrpy if
allowed_hosts
is also usingignore_localhost
andignore_hosts
from the vcr_config to construct the list while retaining backwards compatibility :-)The text was updated successfully, but these errors were encountered: