From 24424baada086d6d3d4119211f646bf4ccc85673 Mon Sep 17 00:00:00 2001 From: Ricardo Martinelli de Oliveira Date: Wed, 5 Jun 2024 03:49:03 -0300 Subject: [PATCH] chore: Change command to apply manifests in the docs (#10864) Signed-off-by: Ricardo M. Oliveira --- backend/src/v2/test/README.md | 2 +- manifests/kustomize/README.md | 4 ++-- manifests/kustomize/env/aws/README.md | 4 ++-- manifests/kustomize/sample/README.md | 4 ++-- manifests/kustomize/sample/kustomization.yaml | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/backend/src/v2/test/README.md b/backend/src/v2/test/README.md index 4ea221c5a31..8a628452a65 100644 --- a/backend/src/v2/test/README.md +++ b/backend/src/v2/test/README.md @@ -146,7 +146,7 @@ Some samples can be used as examples for various cases: 1. Q: I'm getting error `main.go:56] Failed to execute component: unable to get pipeline with PipelineName "pipeline-with-lightweight-io" PipelineRunID "pipeline-with-lightweight-io-pmxzr": Failed PutParentContexts(parent_contexts:{child_id:174 parent_id:173}): rpc error: code = Unimplemented desc =`. - A: You need to upgrade metadata-grpc-service deployment to 1.0.0+. KFP manifest master branch includes the upgrade, but it hasn't been released yet. Therefore, you need to install KFP standalone from master: `kubectl apply -k manifests/kustomize/env/dev`. + A: You need to upgrade metadata-grpc-service deployment to 1.0.0+. KFP manifest master branch includes the upgrade, but it hasn't been released yet. Therefore, you need to install KFP standalone from master: `kustomize build manifests/kustomize/env/dev | kubectl apply -f -`. ## Implementation Details diff --git a/manifests/kustomize/README.md b/manifests/kustomize/README.md index c7e44660aa4..d0b7bfd1825 100644 --- a/manifests/kustomize/README.md +++ b/manifests/kustomize/README.md @@ -18,9 +18,9 @@ Install: ```bash KFP_ENV=platform-agnostic -kubectl apply -k cluster-scoped-resources/ +kustomize build cluster-scoped-resources/ | kubectl apply -f - kubectl wait crd/applications.app.k8s.io --for condition=established --timeout=60s -kubectl apply -k "env/${KFP_ENV}/" +kustomize build "env/${KFP_ENV}/" | kubectl apply -f - kubectl wait pods -l application-crd-id=kubeflow-pipelines -n kubeflow --for condition=Ready --timeout=1800s kubectl port-forward -n kubeflow svc/ml-pipeline-ui 8080:80 ``` diff --git a/manifests/kustomize/env/aws/README.md b/manifests/kustomize/env/aws/README.md index 4502094802e..978adf1f745 100644 --- a/manifests/kustomize/env/aws/README.md +++ b/manifests/kustomize/env/aws/README.md @@ -38,13 +38,13 @@ Follow this [doc](https://awslabs.github.io/kubeflow-manifests/docs/deployment/r 5. Install ``` -kubectl apply -k ../../cluster-scoped-resources +kustomize build ../../cluster-scoped-resources | kubectl apply -f - # If upper one action got failed, e.x. you used wrong value, try delete, fix and apply again # kubectl delete -k ../../cluster-scoped-resources kubectl wait crd/applications.app.k8s.io --for condition=established --timeout=60s -kubectl apply -k ./ +kustomize build ./ | kubectl apply -f - # If upper one action got failed, e.x. you used wrong value, try delete, fix and apply again # kubectl delete -k ./ diff --git a/manifests/kustomize/sample/README.md b/manifests/kustomize/sample/README.md index c4bfe95ba23..4bdd6cbef9d 100644 --- a/manifests/kustomize/sample/README.md +++ b/manifests/kustomize/sample/README.md @@ -63,11 +63,11 @@ gsutil mb -p myProjectId gs://myBucketName/ 6. Install ``` -kubectl apply -k sample/cluster-scoped-resources/ +kustomize build sample/cluster-scoped-resources/ | kubectl apply -f - kubectl wait crd/applications.app.k8s.io --for condition=established --timeout=60s -kubectl apply -k sample/ +kustomize build sample/ | kubectl apply -f - # If upper one action got failed, e.x. you used wrong value, try delete, fix and apply again # kubectl delete -k sample/ diff --git a/manifests/kustomize/sample/kustomization.yaml b/manifests/kustomize/sample/kustomization.yaml index e8bf361dd5f..6c4d0666a19 100644 --- a/manifests/kustomize/sample/kustomization.yaml +++ b/manifests/kustomize/sample/kustomization.yaml @@ -34,5 +34,5 @@ namespace: kubeflow #### Customization ### # 1. Change values in params.env file # 2. Change values in params-db-secret.env file for CloudSQL username and password -# 3. kubectl apply -k ./ +# 3. kustomize build ./ | kubectl apply -f - ####