Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart #312

Closed
TimJones opened this issue Aug 22, 2022 · 1 comment · Fixed by #313
Closed

Helm chart #312

TimJones opened this issue Aug 22, 2022 · 1 comment · Fixed by #313

Comments

@TimJones
Copy link
Contributor

I assume due to #169 that the Helm Chart in this repo shouldn't be considered ready for use.

Before it gets published anywhere I noticed that the template/deployment.yaml is actually a DaemonSet, so it should be renamed accordingly. Also the DaemonSet resources does not support a replicas field in the spec.

@deitch
Copy link
Contributor

deitch commented Aug 22, 2022

Yeah, that was a recent update. I don't care all that much if the file is named deployment.yaml or daemonset.yaml, but it is good hygiene to clean it up.

Most of the testing happens from the direct manifests, not from the Helm chart. We really should auto-generated one from the other, and then we are in a reliable channel all the way through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants