Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated v1 provider id format #2122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove deprecated v1 provider id format #2122

wants to merge 1 commit into from

Conversation

Prajyot-Parab
Copy link
Contributor

What this PR does / why we need it:

  • remove deprecated v1 provider id format

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1917

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

remove deprecated v1 provider id format

@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 8, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 825d2ce
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/6793745408ab16000856f823
😎 Deploy Preview https://deploy-preview-2122--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Amulyam24
Amulyam24 reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@Amulyam24 Amulyam24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prajyot-Parab, we need to remove the cluster-template-powervs also as we no longer use it

Ref - #1868

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2025
Amulyam24
Amulyam24 reviewed Jan 8, 2025
View reviewed changes
main.go Outdated Show resolved Hide resolved
Karthik-K-N
Karthik-K-N reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since we are removing template as well, Lets update the PR description to mention that as well. In future we should not wonder why we removed it.

cloud/scope/machine.go Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@Prajyot-Parab Prajyot-Parab force-pushed the main branch 2 times, most recently from ed72440 to 8fe33f2 Compare January 9, 2025 09:40
@Prajyot-Parab
Copy link
Contributor Author

/cc @mkumatag

@k8s-ci-robot k8s-ci-robot requested a review from mkumatag January 10, 2025 06:14
mkumatag
mkumatag requested changes Jan 17, 2025
View reviewed changes
cloud/scope/machine.go Outdated Show resolved Hide resolved
cloud/scope/powervs_machine_test.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2025
@Prajyot-Parab
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2025
@Prajyot-Parab
Copy link
Contributor Author

cc @Karthik-K-N PTAL

@Prajyot-Parab Prajyot-Parab mentioned this pull request Jan 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag requested changes

@Amulyam24 Amulyam24 Awaiting requested review from Amulyam24

@Karthik-K-N Karthik-K-N Awaiting requested review from Karthik-K-N

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated v1 provider id format
5 participants
@Prajyot-Parab @k8s-ci-robot @mkumatag @Amulyam24 @Karthik-K-N