Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance Windows] Support requiresDowntime in module-config #120

Closed
2 tasks done
lindnerby opened this issue Dec 9, 2024 · 0 comments · Fixed by #132
Closed
2 tasks done

[Maintenance Windows] Support requiresDowntime in module-config #120

lindnerby opened this issue Dec 9, 2024 · 0 comments · Fixed by #132
Assignees

Comments

@lindnerby
Copy link
Member

lindnerby commented Dec 9, 2024

Description

To support the introduced flag requiresDowntime of ModuleTemplate in kyma-project/lifecycle-manager#2100, we need to extend modulectl's create and scaffold commands. Module teams should be able to set this flag in in the config-file for the create command and the scaffold output should scaffold this field as a comment as well.

Reasons

We need to harmonize Kyma related upgrade windows with BTP defined major update windows, so that if module upgrades require downtimes, the upgrade is scheduled within the BTP major upgrade window for the given region and plan.

Because of that we introduce the support of .spec.requiresDowntime with kyma-project/lifecycle-manager#2099. modulectl should also support template creation with this flag initialized by module teams.

Acceptance Criteria

  • Added support for field requiresDowntime in module config-file for create command
  • Added scaffolded field requiresDowntime as comment in module config-file output of scaffold command

Related issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants