Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More precisely determine Impl specialization #37

Open
l2dy opened this issue Aug 24, 2024 · 1 comment
Open

More precisely determine Impl specialization #37

l2dy opened this issue Aug 24, 2024 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@l2dy
Copy link
Owner

l2dy commented Aug 24, 2024

We need to determine if other is a specialization of victim to fix false positive errors of incompatible types.

In commit c8aa7c7, we compare the return type of each Impl members to determine if they are compatible, but it does not cover other cases of incompatibility.

@l2dy l2dy added the help wanted Extra attention is needed label Aug 24, 2024
@nev3rfail
Copy link
Contributor

Maybe we can leverage rust-analyzer to do it for us somehow? I don't think doing stuff like this on your own is reasonable because the bigger the code the harder it will get to maintain.

But I do not have enough knowledge about rust-analyzer / lsps to answer it, so its just a thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants