New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User can set a batch session timeout #2812

Closed

yomybaby opened this issue Nov 5, 2024 · 1 comment · Fixed by #2824

Assignees

Labels

urgency:4

Milestone

Member

yomybaby commented Nov 5, 2024 •

edited

Loading

In session launcher, user can set a batch session timeout.

Core Issue

Let's start implementing the UI even though the API is not ready yet.

yomybaby added this to the 24.12 milestone

yomybaby assigned agatha197

agatha197 mentioned this issue

feat: add batch job timeout duration #2824

Merged

8 tasks

agatha197 added the urgency:4 label

agatha197 added a commit that referenced this issue


          feat: add batch job timeout duration (#2824)

b082f8a

resolves #2812
related PR: lablup/backend.ai#3066

Add batch job timeout duration to the session launcher.
User can select the time unit and input the timeout duration.

**How to test:**
> test endpoint: 10.82.230.49
1. Modify the support version of `batch-timeout` in `backend.ai-client-esm` for testing. (24.09)
2. Set session type to the batch.
3. Enable `Batch Job Timeout Duration`
  - eg
    start command: sleep 20 && echo \"hello world\"
    timeout: 3s

**Checklist:**
- [ ] Batch job timeout value remains after refreshing
- [ ] The 'Confirm and Launch' page has the same value if you set the 'Batch job timeout duration'.
- [ ] (API is not implemented yet) Create a new session with batch session timeout option.

**Screentshots:**
![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/5adbf314-e521-4410-bed8-075124fad6c8.png)

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/c9dd0f12-695e-4960-ba98-9b6371c6a47a.png)

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/4075faa3-a61e-4ce3-833c-c858e6d6b75a.png)

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/600fd8cb-0040-43e4-b8fe-307730d292c0.png)

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/55116de0-e7eb-4ef7-8077-abde8ea73b3b.png)

**Checklist:**

- [ ] Documentation
- [ ] Test case: Verify timeout can be enabled/disabled
- [ ] Test case: Confirm time picker accepts valid duration formats
- [ ] Test case: Check default value initialization
- [ ] Test case: Validate timeout enforcement on batch sessions

Contributor

agatha197 commented Nov 20, 2024

resolved by #2824

agatha197 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment