Hide agent select in Service launcher #2837
Comments
6 tasks
yomybaby
pushed a commit
that referenced
this issue
Nov 25, 2024
This PR resolves [#2837](#2837) **Changes:** Makes agent selection in resource allocation form configurable via a new `enableAgentSelect` prop, defaulting to false. The agent selection field will only display when both `enableAgentSelect` is true and `baiClient._config.hideAgents` is false. **Implementation:** - Added `enableAgentSelect` prop to ResourceAllocationFormItems component - Set `enableAgentSelect` to true in SessionLauncherPage to maintain existing behavior - Agent selection field visibility now requires both configuration flags to be properly set **Testing Steps:** > Prerequisites: > - Create model type vfolder > - Create model-definition.yaml file and upload it to the vfolder you just created in step 1, according to the link [here](https://webui.docs.backend.ai/en/latest/model_serving/model_serving.html#guide-to-steps-for-using-model-service) 1. Set `hideAgents` in config.general to false. 2. Go to Session launcher page and check AgentSelect section is visible. 3. Check whether you can select agent and create a session which is located to the agent you just selected. 4. Go to Service launcher page by clicking `Start Service` button in Serving page and check AgentSelect section is invisible. 5. Check whether service is successfully created **Checklist:** - [ ] Mention to the original issue - [ ] Documentation - [ ] Minimum required manager version - [ ] Specific setting for review - [ ] Minimum requirements to check during review - [x] Test case(s) to demonstrate the difference of before/after
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PR #2599 introduces Agent select, but we need to hide the agent select in the Service launcher until the Service launcher supports it.
The text was updated successfully, but these errors were encountered: