Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session name copy feature occurs runtime errors #2843

Closed
agatha197 opened this issue Nov 12, 2024 · 0 comments · Fixed by #2842
Closed

Session name copy feature occurs runtime errors #2843

agatha197 opened this issue Nov 12, 2024 · 0 comments · Fixed by #2842
Assignees
@agatha197
Labels
type:fix Fix features that are not working
Milestone
24.09

Comments

@agatha197
Copy link
Contributor

What Operating System(s) are you seeing this problem on?

Linux (x86-64)

Backend.AI version

24.09

Describe the bug

Image

To Reproduce

test: 10.100.64.15

  1. click the copy button of KvfwhPMQ-session session.
  2. See error.

Expected Behavior

No response

Anything else?

No response
@agatha197 agatha197 added the type:fix Fix features that are not working label Nov 12, 2024
@agatha197 agatha197 self-assigned this Nov 12, 2024
@agatha197 agatha197 mentioned this issue Nov 12, 2024
Merged
6 tasks
@agatha197 agatha197 added this to the 24.09 milestone Nov 12, 2024
agatha197 added a commit that referenced this issue Nov 19, 2024
@agatha197
fix: improve clipboard handling with optional chaining (#2842)
be6f6b5 
resolves #2843

**Changes:**
Improves clipboard functionality across browsers by:
- Adding optional chaining operators to clipboard API calls for better error handling
- Introducing a new `copyText()` method in session list for cross-browser text copying
- Implementing fallback copy mechanism for browsers without clipboard API support

**Rationale:**
The clipboard operations needed to be more robust across different browsers and handle cases where the clipboard API might be unavailable or restricted.

**Effects:**
- More reliable text copying functionality in session management
- Better error handling for clipboard operations
- Support for browsers without native clipboard API

**Checklist:**
- [ ] Mention to the original issue
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after

**Testing Requirements:**
- Verify clipboard operations in Chrome/Safari
- Test copying functionality in browsers without clipboard API
- Confirm error handling when clipboard access is denied
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agatha197 agatha197

Labels
type:fix Fix features that are not working
Projects
None yet
Milestone
24.09
Development

Successfully merging a pull request may close this issue.

fix: improve clipboard handling with optional chaining lablup/backend.ai-webui
2 participants
@yomybaby @agatha197