feat(FR-244): session renaming in the session detail panel #3034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.94% (-0.01% 🔻) |
398/8054 |
| 🔴 | Branches | 4.27% (-0.01% 🔻) |
239/5591 |
| 🔴 | Functions | 2.96% (-0% 🔻) |
78/2633 |
| 🔴 | Lines | 4.86% (-0.01% 🔻) |
383/7880 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 7d99ac1
yomybaby
changed the title
yomybaby
force-pushed
the
feature/session-renaming-in-detail-panel
branch
from
6fa6038 to
da5f2aa
Compare
ironAiken2
requested review from
ironAiken2,
inureyes and
agatha197
and removed request for
inureyes and
agatha197
ironAiken2
requested changes
Jan 15, 2025
react/src/components/ComputeSessionNodeItems/EditableSessionName.tsx
Outdated
Show resolved
Hide resolved
yomybaby
force-pushed
the
feature/session-renaming-in-detail-panel
branch
from
da5f2aa to
f4e4a4f
Compare
ironAiken2
requested changes
Jan 15, 2025
There was a problem hiding this comment.
It can be modified as a duplicate of another currently existing session name. teams
|
Thank you for mentioning it. Currently, |
Merge activity
|
resolves #3035 (FR-244) Enhances session name editing functionality with improved validation and user experience: - Adds form-based editing interface with validation rules for session names - Implements escape key to cancel editing - Shows visual feedback during editing with a down-left corner icon - Maintains consistent validation rules between initial creation and editing - Enables editing session names directly in the session detail drawer - Restricts editing to session owners and non-preparing states - Prevents accidental drawer closure with keyboard shortcuts while editing **Checklist:** - [ ] Test case: Verify session name validation rules - [ ] Test case: Check escape key cancels editing - [ ] Test case: Confirm editing works in session detail drawer - [ ] Test case: Verify only session owners can edit names - [ ] Test case: Confirm editing is disabled during session preparation
yomybaby
force-pushed
the
feature/session-renaming-in-detail-panel
branch
from
f4e4a4f to
7d99ac1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3035 (FR-244)
Enhances session name editing functionality with improved validation and user experience:
Checklist: