Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem occurs with installing a new image #3043

Open
ironAiken2 opened this issue Jan 17, 2025 — with Lablup-Issue-Syncer · 0 comments · Fixed by #3042
Open

Problem occurs with installing a new image #3043

ironAiken2 opened this issue Jan 17, 2025 — with Lablup-Issue-Syncer · 0 comments · Fixed by #3042
Assignees
@ironAiken2

Comments

@ironAiken2
Copy link
Contributor

Image installation fails. The same as creating the model service, you get an error that the image is not found. Again, validation in a different environment is required.
@ironAiken2 ironAiken2 self-assigned this Jan 17, 2025
@ironAiken2 ironAiken2 mentioned this issue Jan 17, 2025
Merged
5 tasks
yomybaby pushed a commit that referenced this issue Jan 17, 2025
@ironAiken2
fix(FR-382, FR-384): Handle deprecated image name fields in service l…
5e36c40 
…auncher and image download (#3042)

resolves #3043 (FR-384) #3044 (FR-382)

Introduces a new `namespace` field for image objects while deprecating the existing `name` field. This change affects how image names are constructed throughout the application, particularly in the image installation modal, service launcher, and endpoint detail pages.

The image name construction now prioritizes the `namespace` field, falling back to `name` when namespace is not available: `registry/namespace:tag` or `registry/name:tag`.

**Checklist:**
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ironAiken2 ironAiken2

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ironAiken2