fix(FR-382, FR-384): Handle deprecated image name fields in service launcher and image download #3042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
ironAiken2
force-pushed
the
fix/handling-deprecated-name-field
branch
from
2b16f2c to
53437f5
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.93% | 398/8074 |
| 🔴 | Branches | 4.25% (-0.01% 🔻) |
239/5617 |
| 🔴 | Functions | 2.95% | 78/2640 |
| 🔴 | Lines | 4.85% | 383/7899 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 5e36c40
ironAiken2
force-pushed
the
fix/handling-deprecated-name-field
branch
from
53437f5 to
70fa7d9
Compare
yomybaby
requested changes
Jan 17, 2025
ironAiken2
force-pushed
the
fix/handling-deprecated-name-field
branch
from
70fa7d9 to
91dca1f
Compare
Merge activity
|
…auncher and image download (#3042) resolves #3043 (FR-384) #3044 (FR-382) Introduces a new `namespace` field for image objects while deprecating the existing `name` field. This change affects how image names are constructed throughout the application, particularly in the image installation modal, service launcher, and endpoint detail pages. The image name construction now prioritizes the `namespace` field, falling back to `name` when namespace is not available: `registry/namespace:tag` or `registry/name:tag`. **Checklist:** - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
yomybaby
force-pushed
the
fix/handling-deprecated-name-field
branch
from
07aff36 to
5e36c40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3043 (FR-384) #3044 (FR-382)
Introduces a new
namespacefield for image objects while deprecating the existingnamefield. This change affects how image names are constructed throughout the application, particularly in the image installation modal, service launcher, and endpoint detail pages.The image name construction now prioritizes the
namespacefield, falling back tonamewhen namespace is not available:registry/namespace:tagorregistry/name:tag.Checklist: