You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Docstrings for scipy.optimize.minimize and scipy.optimize.minimize_scalar are explicitly included. Is there a good reason for doing this instead of adopting the strategy followed for scico.numpy (i.e. automatically attach the docstrings when running sphinx)?
The split and join functions should be made private
The text was updated successfully, but these errors were encountered:
Re: 3rd point, go ahead and do it automatically. Be sure to leave the part describing the differences! eg the part “This function differs from scipy.optimize.minimize in three ways…”
Automatic inclusion of the docs from scipy.optimize is greatly complicated by the inclusion of only part of the docstring. One could make it work, but it would be pretty fragile. I'm strongly leaning towards just removing the explicit copy (which is a maintenance nightmare) and relying on the cross-reference to the full docs.
Some issues related to the API docs for the
scico.solver
module:.. todo:
in the module header docstring.TODO
comments in the code (see Address TODO comments in code #96).scipy.optimize.minimize
andscipy.optimize.minimize_scalar
are explicitly included. Is there a good reason for doing this instead of adopting the strategy followed forscico.numpy
(i.e. automatically attach the docstrings when running sphinx)?The text was updated successfully, but these errors were encountered: