Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry page displays delayed jobs #132

Open
juanibiapina opened this issue Mar 21, 2016 · 4 comments
Open

Retry page displays delayed jobs #132

juanibiapina opened this issue Mar 21, 2016 · 4 comments

Comments

@juanibiapina
Copy link

When I open the retry page on resque-web, I can see 67 pages of "retry" jobs. But these aren't actually retry jobs, they're the same delayed jobs I see on the delayed page.

Why not display only the retry jobs there? (possibly the ones starting with "resque-retry")

@lantins
Copy link
Owner

lantins commented Mar 21, 2016

We use delayed jobs to implement retry, but yes, I think your right normal delayed jobs will also be included in the list.

You could do this by checking retry_attempts_for_job, if the count does not exist, its not a retry job so can be ignored.

We'd very much appreciate a pull request, are you game @juanibiapina ? :)

@jzaleski This looks very possible to me, do you know of any reason we shouldn't ignore jobs that don't have a retry count?

@juanibiapina
Copy link
Author

I would like to, but I unfortunately I don't have the time right now.

@juanibiapina
Copy link
Author

Looking at the code it seems the change is not trivial (for me) because jobs are grouped by timestamp.

I don't know exactly what this grouping by timestamp achieves, so I'm not comfortable making the change.

@juanibiapina
Copy link
Author

juanibiapina commented May 30, 2016

A simpler thing would probably be to remove this timestamp logic and only list jobs, but that would change the pagination logic as well. No idea how to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants