Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the setup wizard, default facility / device settings allow an unnecessary level of access from outside the app #106

Open
dylanmccall opened this issue Jun 3, 2024 · 0 comments

Comments

@dylanmccall
Copy link
Collaborator

dylanmccall commented Jun 3, 2024

If I use the setup wizard in the kolibri-gnome app, Kolibri uses some default facility and device settings. In general, these are fine because the app plugin disables access from other browsers on its own. But I am concerned about:

  • facility_settings.learner_can_sign_up = True

While this is a good default for Kolibri in general, I don't think it's a good default in this situation, because the promise of an app is it is self-contained. A user might be rather surprised to find that anyone else on the network who knows how to reach Kolibri will be able to create a learner account for as long as the app is running.

Instead, we should consider overriding this so Kolibri as an app is more self-contained. But ideally this is work that happens in Kolibri itself, perhaps with an addition to options.ini.

dylanmccall added a commit that referenced this issue Jun 3, 2024
This feature is no longer useful due to improvements to Kolibri's setup
wizard. The default settings are more permissive than before, but this
is an issue that should be addressed in Kolibri itself:
#106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant