Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup / reformatting of "fle_win32_framework.h" #99

Open
ruimalheiro opened this issue May 10, 2019 · 0 comments
Open

Cleanup / reformatting of "fle_win32_framework.h" #99

ruimalheiro opened this issue May 10, 2019 · 0 comments

Comments

@ruimalheiro
Copy link

ruimalheiro commented May 10, 2019

As the framework was never completed 😂 , there might be some code that can be removed or refactored. Example:

void fle_BaseWindow::test()
{
	static const TCHAR * str = TEXT("WELCOME FLE FRAMEWORKKKKKKKKKK\n");
    OutputDebugString(str);
};

The initial intention was to add the ability of building any kind of widget but since it was never required, maybe there is no point in keeping all the abstraction and instead, simplify the code to just handle the tray menus "properly". This should keep it simple to maintain.

There are also some unhandled errors that can lead to bugs. Example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant