Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create route for Quotes Endpoint #143

Closed
lelouchB opened this issue Nov 17, 2020 · 10 comments · Fixed by #144
Closed

Create route for Quotes Endpoint #143

lelouchB opened this issue Nov 17, 2020 · 10 comments · Fixed by #144
Assignees
Labels
backend enhancement New feature or request

Comments

@lelouchB
Copy link
Owner

#140
To Do

  • Create quote.model.js under backend/models
  • Create quote.api.js in backend/controllers directory
  • Add quotes to routes/routes.js
  • Add quote to config/endpoints.js
@lelouchB lelouchB added enhancement New feature or request backend labels Nov 17, 2020
@Mayank0255
Copy link
Contributor

@lelouchB What's the difference between the two issues?

@lelouchB
Copy link
Owner Author

@lelouchB What's the difference between the two issues?

That is the global issue around this whole endpoint.

This is a specific issue.

After this is done. I will create issues for documentation.

Can I assign this to you?

@Mayank0255
Copy link
Contributor

Sure no issues

@Mayank0255
Copy link
Contributor

@lelouchB What routes do you need me to add?

Just GET all quotes?

@lelouchB
Copy link
Owner Author

@lelouchB What routes do you need me to add?

Just GET all quotes?

Yes for now GET all quotes is fine.
I am also thinking of adding a filter of name in this endpoint where users can give a query something like /api/v0/quote/gary or /api/v0/quote?by=gary_goodspeed. Just a thought.

But yeah, for now GET all is perfect.
Also add the sort and limit config as added in other endpoints.

@Mayank0255
Copy link
Contributor

@lelouchB

Cool would do all that and ping me after this issue when you think of implementing the filtering thing and other routes

@lelouchB
Copy link
Owner Author

Of course
Will do so.

@Mayank0255
Copy link
Contributor

Where to write the test for the route? And I have to write the docs for quotes as well write?

Mayank0255 added a commit to Mayank0255/final-space-api that referenced this issue Nov 17, 2020
Mayank0255 added a commit to Mayank0255/final-space-api that referenced this issue Nov 17, 2020
Mayank0255 added a commit to Mayank0255/final-space-api that referenced this issue Nov 17, 2020
@lelouchB
Copy link
Owner Author

There are no tests as of now. It is under development by @JuanVqz

It's your choice, you can write the docs or just work on the code.
I will either create an issue and assign someone for the documentation or write them myself.

@Mayank0255
Copy link
Contributor

Okay then will just create a PR

lelouchB pushed a commit that referenced this issue Nov 18, 2020
@lelouchB lelouchB linked a pull request Nov 18, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants