-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NodeJS CI Workflow #5
Comments
I've worked with github actions/workflows before. Can I take this one after the tests are written? |
@trybick In this Workflow, we will add both these tests. |
I'm happy to do the workflow, but will pass on the tests, but thanks for the offer. |
Hey @trybick Let me know if you have any questions. |
Yes I can start on the workflow - I should be able to start it tonight or next night 👍 |
Great 👍 P.S. no deploy command needed, only build Thanks :) |
@lelouchB I am confused about those two links - the original issue at the top has an example of a github workflow to run the tests, right? I thought that would do it |
Yes, the issue is for tests but there are no tests for After the Does this make sense? |
Still a little confused - We want a workflow to run the tests but those are on hold until backend tests are done. In the mean time we want to a workflow to run the build command? Does it need to deploy anywhere - or just check that build is successful? |
Yes that's correct. I am fine with |
Ok, just to confirm, the build workflow would just confirm the build is successful and then exit right? If we wanted to deploy too I think that would involve a lot more |
Yes, it will tell if the build is successful and then exit. Thanks |
Ok, thanks for clarifying! |
Hey @trybick Thanks |
Hey @lelouchB sure! Would that be a new workflow to just run the lint command in the backend? I also was thinking, would you want a pre-commit hook added? - so every time someone commits it lints and prettifies the code - an option if you want to consider :) |
Yes yes that pre commit hook would be amazing too. |
Relies on #2 i.e. after Tests have been written.
Here is a possible
The text was updated successfully, but these errors were encountered: