Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time module #30

Open
ctombumila37 opened this issue Feb 19, 2019 · 14 comments
Open

Time module #30

ctombumila37 opened this issue Feb 19, 2019 · 14 comments
Labels
feature request Indicates new feature requests. good first issue Indicates a good issue for first-time contributors. skill Indicates that an issue related to a skill (previously named as package/module).

Comments

@ctombumila37
Copy link
Contributor

Feature Use Case

Leon, what time is it?
- It's quarter past ten.

Feature Proposal

Implement a new module / package.

@ctombumila37 ctombumila37 added the feature request Indicates new feature requests. label Feb 19, 2019
@louistiti louistiti added the good first issue Indicates a good issue for first-time contributors. label Feb 20, 2019
@louistiti
Copy link
Member

@louistiti
Copy link
Member

Hello @ctombumila37,

Thanks for this feature request.

This is definitely a module that can be done with the current version (1.0.0-beta.0).

Is that something you would like to work on?

@hk1997
Copy link

hk1997 commented Feb 20, 2019

Can I work on this feature?

@louistiti
Copy link
Member

Hello @hk1997,

Yes with pleasure. Let's wait a moment to see if @ctombumila37 did not start anything first.

@ctombumila37
Copy link
Contributor Author

Sorry for the delayed response.

@hk1997 Feel free to go ahead :)

@hk1997
Copy link

hk1997 commented Feb 26, 2019

sure, I am starting it then. thanks

@louistiti
Copy link
Member

Awesome! Please reference this issue to the PR 👍

@louistiti
Copy link
Member

louistiti commented Mar 9, 2019

A PR has been created for that #53.

@louistiti louistiti added the skill Indicates that an issue related to a skill (previously named as package/module). label Mar 30, 2019
@rohithjayaraman
Copy link

Is this done or still open ?

@louistiti
Copy link
Member

@theparselmouth it is done based on an old codebase, so you can adapt it to the latest Leon version if you want and try to improve it.

@sagamji100
Copy link

sagamji100 commented Jun 29, 2020

Interesting

@abhaybhatt
Copy link

Can i work on this?

@sanchitsharma
Copy link

Can I work on improving the open PR? Would someone be available for review?

@louistiti
Copy link
Member

Hi @sanchitsharma 👋,

Thanks for willing to contribute into Leon! At this stage I'd say it'd be better to wait for upcoming versions but feel free to improve the current PR. All the PRs will be merged once some upcoming versions will be released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Indicates new feature requests. good first issue Indicates a good issue for first-time contributors. skill Indicates that an issue related to a skill (previously named as package/module).
Projects
None yet
Development

No branches or pull requests

7 participants