Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding advanced example dataset #267

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: adding advanced example dataset #267

wants to merge 5 commits into from

Conversation

MarIniOnz
Copy link
Contributor

Adding an advanced example dataset with 600 patients with call:

medmodels.MedRecord.from_advanced_example_dataset()
  • Also changing the name of the temporal attributes in the basic example dataset to "time" so that they are unified and the querying is easier

@MarIniOnz MarIniOnz requested review from JabobKrauskopf and a team as code owners December 2, 2024 13:22
@MarIniOnz MarIniOnz linked an issue Dec 2, 2024 that may be closed by this pull request
Add advanced example dataset #253
Open
@MarIniOnz MarIniOnz force-pushed the 253-add-advanced-example-dataset branch from 96bacd4 to 0a3f443 Compare December 2, 2024 13:48
LauraBoenchenLB
LauraBoenchenLB requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@LauraBoenchenLB LauraBoenchenLB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Will be very useful for testing and trying out new methods in the future!

crates/medmodels-core/src/medrecord/advanced_example_dataset/synthetic_data/README.md Outdated Show resolved Hide resolved
crates/medmodels-core/src/medrecord/advanced_example_dataset/synthetic_data/README.md Outdated Show resolved Hide resolved
crates/medmodels-core/src/medrecord/advanced_example_dataset/synthetic_data/README.md Outdated Show resolved Hide resolved
crates/medmodels-core/src/medrecord/advanced_example_dataset/synthetic_data/README.md Outdated Show resolved Hide resolved
crates/medmodels-core/src/medrecord/advanced_example_dataset/synthetic_data/README.md Outdated Show resolved Hide resolved
crates/medmodels-core/src/medrecord/advanced_example_dataset/synthetic_data/README.md Outdated Show resolved Hide resolved
crates/medmodels-core/src/medrecord/example_dataset/synthetic_data/README.md Outdated Show resolved Hide resolved
crates/medmodels-core/src/medrecord/example_dataset/synthetic_data/README.md Outdated Show resolved Hide resolved
crates/medmodels-core/src/medrecord/example_dataset/synthetic_data/README.md Outdated Show resolved Hide resolved
medmodels/medrecord/medrecord.py Show resolved Hide resolved
LauraBoenchenLB
LauraBoenchenLB previously approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@LauraBoenchenLB LauraBoenchenLB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't speak for the Rust part, but the rest looks good to me now! 🦭

@MarIniOnz MarIniOnz force-pushed the 253-add-advanced-example-dataset branch from e4bb073 to 630cfcd Compare December 18, 2024 11:46
JabobKrauskopf
JabobKrauskopf requested changes Jan 2, 2025
View reviewed changes
Copy link
Member

@JabobKrauskopf JabobKrauskopf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good job!

One structural request:
I don't think the advanced_example_dataset should be an extra module. Instead, combine it with the existing example_dataset module. The structure should look something like this:

example_dataset/
├─ synthetic_data/
│  ├─ simple_dataset/
│  │  └─ csv files and README
│  └─ advanced_dataset/
│     └─ csv files and README
└─ mod.rs

Imo we can also rename the current from_example_dataset to from_simple_example_dataset to make it consistent with the from_example_dataset

crates/medmodels-core/src/medrecord/advanced_example_dataset/synthetic_data/event.csv Outdated Show resolved Hide resolved
medmodels/medrecord/tests/test_schema.py Show resolved Hide resolved
crates/medmodels-core/src/medrecord/advanced_example_dataset/mod.rs Outdated Show resolved Hide resolved
JabobKrauskopf
JabobKrauskopf requested changes Jan 2, 2025
View reviewed changes
Copy link
Member

@JabobKrauskopf JabobKrauskopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there! Some minor requests, mainly related to testing

medmodels/medrecord/tests/test_schema.py Show resolved Hide resolved
crates/medmodels-core/src/medrecord/example_dataset/mod.rs Show resolved Hide resolved
crates/medmodels-core/src/medrecord/example_dataset/synthetic_data/advanced_dataset/README.md Outdated Show resolved Hide resolved
medmodels/medrecord/tests/test_medrecord.py Show resolved Hide resolved
LauraBoenchenLB
LauraBoenchenLB requested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@LauraBoenchenLB LauraBoenchenLB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few tiny improvements for the grammar of the description, otherwise very happy with the added dataset and code!

crates/medmodels-core/src/medrecord/example_dataset/synthetic_data/advanced_dataset/README.md Outdated Show resolved Hide resolved
crates/medmodels-core/src/medrecord/example_dataset/synthetic_data/advanced_dataset/README.md Outdated Show resolved Hide resolved
crates/medmodels-core/src/medrecord/example_dataset/synthetic_data/advanced_dataset/README.md Outdated Show resolved Hide resolved
crates/medmodels-core/src/medrecord/example_dataset/synthetic_data/advanced_dataset/README.md Outdated Show resolved Hide resolved
crates/medmodels-core/src/medrecord/example_dataset/synthetic_data/advanced_dataset/README.md Outdated Show resolved Hide resolved
crates/medmodels-core/src/medrecord/example_dataset/synthetic_data/advanced_dataset/README.md Outdated Show resolved Hide resolved
crates/medmodels-core/src/medrecord/example_dataset/synthetic_data/advanced_dataset/README.md Outdated Show resolved Hide resolved
crates/medmodels-core/src/medrecord/example_dataset/synthetic_data/simple_dataset/README.md Outdated Show resolved Hide resolved
crates/medmodels-core/src/medrecord/example_dataset/synthetic_data/simple_dataset/README.md Outdated Show resolved Hide resolved
crates/medmodels-core/src/medrecord/example_dataset/synthetic_data/simple_dataset/README.md Outdated Show resolved Hide resolved
LauraBoenchenLB
LauraBoenchenLB previously approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@LauraBoenchenLB LauraBoenchenLB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side (hopefully) last approval! :) 🦭

@MarIniOnz MarIniOnz force-pushed the 253-add-advanced-example-dataset branch 2 times, most recently from 53c38bd to 2a5bb1a Compare January 7, 2025 09:48
@MarIniOnz MarIniOnz force-pushed the 253-add-advanced-example-dataset branch from 2a5bb1a to e6f552d Compare January 7, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OFranke OFranke Awaiting requested review from OFranke OFranke is a code owner automatically assigned from limebit/medmodels-software-engineering

@FloLimebit FloLimebit Awaiting requested review from FloLimebit FloLimebit is a code owner automatically assigned from limebit/medmodels-software-engineering

@philippgrosser philippgrosser Awaiting requested review from philippgrosser philippgrosser is a code owner automatically assigned from limebit/medmodels-data-science-team

@JabobKrauskopf JabobKrauskopf Awaiting requested review from JabobKrauskopf JabobKrauskopf is a code owner

@LauraBoenchenLB LauraBoenchenLB Awaiting requested review from LauraBoenchenLB

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add advanced example dataset
3 participants
@MarIniOnz @JabobKrauskopf @LauraBoenchenLB