Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default values for essential_covariates in TreatmentEffect #254

Open
JabobKrauskopf opened this issue Nov 18, 2024 · 0 comments · May be fixed by #256
Open

Default values for essential_covariates in TreatmentEffect #254

JabobKrauskopf opened this issue Nov 18, 2024 · 0 comments · May be fixed by #256
Assignees
@MarIniOnz
Labels
p-low Priority: Low python Related to the python medmodels refactor Related to refactoring

Comments

@JabobKrauskopf
Copy link
Member

JabobKrauskopf commented Nov 18, 2024 •
edited by MarIniOnz
Loading

Removing "gender" and "age" as default values of the TreatmentEffect "essential_covariates" arguments in control group matching functions. Add "all attributes" as essential ones.

Remove also default values for "one-hot-covariates". In the future, implement a way to look (if schema provided) which attributes are categorical.
@JabobKrauskopf JabobKrauskopf added python Related to the python medmodels refactor Related to refactoring p-low Priority: Low labels Nov 18, 2024
@MarIniOnz MarIniOnz self-assigned this Nov 18, 2024
@MarIniOnz MarIniOnz linked a pull request Nov 19, 2024 that will close this issue
fix: the way essential covariates and one-hot-encoded ones are processed #256
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarIniOnz MarIniOnz

Labels
p-low Priority: Low python Related to the python medmodels refactor Related to refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: the way essential covariates and one-hot-encoded ones are processed limebit/medmodels
2 participants
@JabobKrauskopf @MarIniOnz