Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing treatment effect node within time window #272

Open
MarIniOnz opened this issue Dec 3, 2024 · 0 comments
Open

fixing treatment effect node within time window #272

MarIniOnz opened this issue Dec 3, 2024 · 0 comments
Assignees
@MarIniOnz
Labels
fix Related to fixing a bug p-high Priority: High python Related to the python medmodels

Comments

@MarIniOnz
Copy link
Contributor

MarIniOnz commented Dec 3, 2024 •
edited
Loading

Right now, the method self._query_node_within_time_window() is not working as intended, since it takes the maximum or minimum times for the treatment over the WHOLE MedRecord. We need it to be only for that node in specific.

That means a worse performance overall (we will need to see if we can tackle this) for fixed bug.
@MarIniOnz MarIniOnz self-assigned this Dec 3, 2024
@MarIniOnz MarIniOnz added python Related to the python medmodels fix Related to fixing a bug p-high Priority: High labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarIniOnz MarIniOnz

Labels
fix Related to fixing a bug p-high Priority: High python Related to the python medmodels
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

272-fixing-treatment-effect-node-within-time-window limebit/medmodels
1 participant
@MarIniOnz