Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge version.rb for v1 and v2 #371

Open
Yang-33 opened this issue Jan 21, 2025 · 4 comments
Open

Merge version.rb for v1 and v2 #371

Yang-33 opened this issue Jan 21, 2025 · 4 comments

Comments

@Yang-33
Copy link
Contributor

Yang-33 commented Jan 21, 2025

I believe it's mainly for user-agent.

There are 2 version.rb in current master branch, and we should update all of them on release. If possible, we should only have 1 version.rb for maintainability.

module Line
module Bot
module API
VERSION = "1.29.0"
end
end
end

module Line
module Bot
module V2
VERSION = "2.0.0"
end
end
end

@k-yamanaka-uuuo
Copy link

hi.

I may be mistaken, but it seems that simply adding the latest line-bot-sdk-ruby to the Gemfile does not allow access to the v2 API. As far as I understand, we need to generate the client library ourselves using the OpenAPI Generator. If there is a simpler way to use the v2 API, I would appreciate clarification.

That said, I think that the v2 code is clean, and easy to use. It’s a significant improvement over the v1.

As you may know, LINE Notify will be discontinued in March, which makes migrating to the new API even more critical. To ensure developers can easily adopt the v2 API, it would be highly beneficial if we could install and use it via gem install.

Thank you for your continued work on this SDK, and I hope the v2 code becomes more accessible soon!

@k-yamanaka-uuuo
Copy link

I realized that this issue is already being addressed as part of a defined milestone.
I apologize for overlooking this detail in my initial comment.

Thank you for your continued efforts on improving this SDK. Your work is greatly appreciated.

@Yang-33
Copy link
Contributor Author

Yang-33 commented Jan 24, 2025

Thank you for watching this repository and kindly feedback, @k-yamanaka-uuuo !

We are currently in the process of implementing v2. It hasn't been published to RubyGems yet because it's not complete and we're verifying the quality within the team. This is intentional, not a mistake.

By the way, even if it's not registered on Rubygems, you should be able to incorporate the code published on GitHub into your application by editing the Gemfile. However, since it's an unreleased feature, we don't guarantee its functionality. This is because further changes might still be made.

gem 'line-bot-api', github: 'line/line-bot-sdk-ruby', branch: 'master'

Your comment doesn't seem related to this issue, so if a discussion is needed, please open a separate issue.

@k-yamanaka-uuuo
Copy link

I wasn’t aware of this method, so I truly appreciate the opportunity to learn something new.

As you mentioned, my comment isn’t directly related to this issue, and I completely understand. No problem at all!

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants