Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do gracefull error handling instead of panicing #39

Open
KarlK90 opened this issue Sep 25, 2023 · 0 comments
Open

Do gracefull error handling instead of panicing #39

KarlK90 opened this issue Sep 25, 2023 · 0 comments

Comments

@KarlK90
Copy link
Member

KarlK90 commented Sep 25, 2023

The current implementation is riddled with .unwrap() calls at fallible places e.g. when setting up the display of the LXA-TAC. A panic will bring down the whole application without a meaningful error message - even in cases where a degradation of the service quality (e.g. loss of the Display) would be an acceptable error state. A better error handling would identify:

  1. Critical non recoverable errors - it is okay to bring down the whole application in this case - but with appropriate error messages.
  2. Critical recoverable errors, where we attempt to recover from the error state or otherwise either move to 1.
  3. Non Critical errors - we shall never panic in this case but inform the user about the degradation of the service quality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant