Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwind 4 compatibility #811

Open
calebporzio opened this issue Dec 4, 2024 · 11 comments · May be fixed by #1009
Open

Tailwind 4 compatibility #811

calebporzio opened this issue Dec 4, 2024 · 11 comments · May be fixed by #1009

Comments

@calebporzio
Copy link
Contributor

calebporzio commented Dec 4, 2024

This issue will house sub-issues related to Tailwind 4 compatibility

@calebporzio calebporzio changed the title Tailwind Tailwind 4 compatibility Dec 4, 2024
@nmfirdausw
Copy link

nmfirdausw commented Jan 9, 2025

Had issue with searchable select here with Tailwind v4.

The list is not filtered when search,
No results found is shown at the bottom,
And the check Icon show at above of the selection, not side by side

Image

@joshhanley
Copy link
Member

@nmfirdausw thanks for the info! Yep, see the linked issue #783 with what is going on. We will investigate it once it gets closer to the release incase it's just a bug with Tailwind 4.

@marksalmon
Copy link

marksalmon commented Jan 16, 2025

@nmfirdausw If you want a quick and dirty fix while you're waiting, it can be done by publishing the select component and tweaking the following tailwind utility classes:

options.blade.php

- <ui-empty class="data-[hidden]:hidden">{{ $empty }}</ui-empty>
+ <ui-empty class="data-hidden:hidden!">{{ $empty }}</ui-empty>
option.blade.php

$classes = Flux::classes()
-   ->add('group/option overflow-hidden data-[hidden]:hidden group flex items-center px-2 py-1.5 w-full focus:outline-none')
+   ->add('group/option overflow-hidden data-hidden:hidden! group flex! items-center px-2 py-1.5 w-full focus:outline-none')
empty.blade.php

$classes = Flux::classes()
-   ->add('data-[hidden]:hidden block items-center px-2 py-1.5 w-full')
+   ->add('data-hidden:hidden! block items-center px-2 py-1.5 w-full')

@nmfirdausw
Copy link

@marksalmon Thanks. Will use that for a while.

@joshhanley joshhanley linked a pull request Jan 22, 2025 that will close this issue
@timkley
Copy link

timkley commented Jan 23, 2025

FYI, Tailwind CSS v4 has been released: https://tailwindcss.com/blog/tailwindcss-v4

@joshhanley
Copy link
Member

@timkley thanks!

@joshhanley
Copy link
Member

@timgavin yeah Flux currnently isn't compatible with Tailwind V4. We've got a solution but it has breaking changes, so we're just working through that at the moment. See https://x.com/calebporzio/status/1881450082459070494

@timgavin
Copy link

timgavin commented Jan 25, 2025

@timgavin yeah Flux currnently isn't compatible with Tailwind V4. We've got a solution but it has breaking changes, so we're just working through that at the moment. See https://x.com/calebporzio/status/1881450082459070494

I looked on his account and totally missed that! thanks!

Deleted my comment so as to not clutter up the thread.

@cjmellor
Copy link

I haven't seen it mentioned anywhere else, so it might just be me, but I doubt it as everything was fine prior to the upgrade.

I know there was a dark mode bug fixed in the latest release, but after upgrading to v4, that has stopped working again. Perhaps something to do with how dark mode is handled now in v4?

@custom-variant dark (&:where(.dark, .dark *));

Just wanted to bring this to attention in case it was a bug.

@jeffchown
Copy link

@cjmellor Per @joshhanley 's comment yesterday (#811 (comment)), Flux is not yet Tailwind v4 compatible.

@joshhanley
Copy link
Member

@cjmellor thanks! Yep, I found that dark mode issue when I was testing the other week, so it should be fixed once we release Tailwind v4 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants