Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code #4

Open
3 tasks
llrs opened this issue Nov 13, 2020 · 2 comments
Open
3 tasks

Improve code #4

llrs opened this issue Nov 13, 2020 · 2 comments

Comments

@llrs
Copy link
Owner

llrs commented Nov 13, 2020

This program is getting some users, so it might be worth to improve it a bit more:

Relevant sources:

@durvasa
Copy link
Collaborator

durvasa commented Nov 15, 2020

I agree it might be worth putting some extra time to improve this.
@llrs I like the points you raise.
It might also be convenient to:

  • add jupyter notebooks to portray functionality
  • refurbish the README

@llrs
Copy link
Owner Author

llrs commented Nov 15, 2020

Created a new branch packaging to test this (I'm not that familiar with distributing python packages).

Not sure how does the version dependencies work on python work (I think they are usually set up as exactly as possible and then dealt with environments), but there is a problem with the biopython 1.78 and the Bio.Alphabet we import:

sudo -H python3 -m pip install -e . # On the packaging branch
python3
>>> import cozmic
...

ImportError: Bio.Alphabet has been removed from Biopython. In many cases, the alphabet can simply be ignored and removed from scripts. In a few cases, you may need to specify the molecule_type as an annotation on a SeqRecord for your script to work correctly. Please see https://biopython.org/wiki/Alphabet for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants