Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-picks for MLIR in 17.0 release #64553

Closed
joker-eph opened this issue Aug 9, 2023 · 15 comments · Fixed by llvm/llvm-project-release-prs#562
Closed

Cherry-picks for MLIR in 17.0 release #64553

joker-eph opened this issue Aug 9, 2023 · 15 comments · Fixed by llvm/llvm-project-release-prs#562

Comments

@joker-eph
Copy link
Collaborator

Catch-all for the on-going cherry-picks about MLIR into the 17 release

@llvmbot
Copy link
Member

llvmbot commented Aug 9, 2023

@llvm/issue-subscribers-mlir

@joker-eph
Copy link
Collaborator Author

@llvmbot
Copy link
Member

llvmbot commented Aug 9, 2023

Failed to cherry-pick: 28fef90

https://github.com/llvm/llvm-project/actions/runs/5807807286

Please manually backport the fix and push it to your github fork. Once this is done, please add a comment like this:

/branch <user>/<repo>/<branch>

@joker-eph
Copy link
Collaborator Author

/branch joker-eph/llvm-project/mlir-17.0.0

@llvmbot
Copy link
Member

llvmbot commented Aug 10, 2023

/pull-request llvm/llvm-project-release-prs#562

@tru tru moved this from Needs Triage to Needs Review in LLVM Release Status Aug 10, 2023
@tru tru moved this from Needs Review to Done in LLVM Release Status Aug 10, 2023
@joker-eph joker-eph reopened this Aug 28, 2023
@joker-eph
Copy link
Collaborator Author

More fixes:

/branch joker-eph/llvm-project/mlir-fixes-17.x

@joker-eph
Copy link
Collaborator Author

/branch joker-eph/llvm-project/mlir-fixes-17.x

@llvmbot
Copy link
Member

llvmbot commented Aug 28, 2023

/pull-request llvm/llvm-project-release-prs#653

@joker-eph
Copy link
Collaborator Author

joker-eph commented Aug 28, 2023

@tru : I reused this issue and the bot created a new PR, but the "project" part of the issue says "Done" so I don't know if it'll be on your radar?
Should the bot move back issue in "triage" when a pull-request is open?

Screenshot 2023-08-28 at 12 22 35 PM

@tru tru moved this from Done to Needs Merge in LLVM Release Status Aug 28, 2023
@tru
Copy link
Collaborator

tru commented Aug 28, 2023

@tru : I reused this issue and the bot created a new PR, but the "project" part of the issue says "Done" so I don't know if it'll be on your radar? (and it seems I can't open the project page)

Screenshot 2023-08-28 at 12 22 35 PM

Thanks for the ping. I have moved the state of it.

It's probably better if we add a new issue for each PR that should be merged, that way I'll notice it directly. Or maybe it doesn't matter that much if you ping me!

@joker-eph
Copy link
Collaborator Author

/branch joker-eph/llvm-project/mlir-fixes-17.x

1 similar comment
@joker-eph
Copy link
Collaborator Author

/branch joker-eph/llvm-project/mlir-fixes-17.x

@joker-eph
Copy link
Collaborator Author

/branch joker-eph/llvm-project/mlir-fixes-17.x-2

@joker-eph
Copy link
Collaborator Author

/branch joker-eph/llvm-project/mlir-fixes-17.x

@tru
Copy link
Collaborator

tru commented Aug 31, 2023

These changes are now merged and done.

@tru tru closed this as completed Aug 31, 2023
@tru tru moved this from Needs Merge to Done in LLVM Release Status Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment