Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deprecate kubernetes-version flag in vcluster create #2389

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: deprecate kubernetes-version flag in vcluster create #2389

wants to merge 1 commit into from

Conversation

kale-amruta
Copy link

@kale-amruta kale-amruta commented Jan 9, 2025 •
edited
Loading

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #2294

Please provide a short message that should be published in the vcluster release notes
Deprecated the kubernetes-version flag in vcluster createcommand, kubernetes version can now be configured from values.yaml.

What else do we need to know?

Deprecation note:

vcluster create v3 --kubernetes-version 1.27.16
Flag --kubernetes-version has been deprecated, please specify the kubernetes version by setting "controlPlane.distro.k8s.version" accordingly via values.yaml file.
17:17:45 info Using vCluster driver 'helm' to create your virtual clusters, which means the vCluster CLI is running helm commands directly

Since the flag is deprecated, the warning related to only supporting major.minor is also removed which will no longer makes sense.

@netlify Netlify
Copy link

netlify bot commented Jan 9, 2025 •
edited
Loading

✅ Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit f459b87
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/677fb949ad1d4700084736a9

@kale-amruta kale-amruta marked this pull request as ready for review January 9, 2025 11:56
@kale-amruta kale-amruta changed the title fix(vclusterctl): deprecate kubernetes-version flag in vcluster create fix: deprecate kubernetes-version flag in vcluster create Jan 9, 2025
@felipecrs
Copy link
Contributor

@kale-amruta, I don't think it makes sense to deprecate something that doesn't even work anymore.

So, I think you should drop all the logic behind this flag and even remove the flag itself.

When using it, it should fail to indicate that it's not supported and avoid the confusion of #2294.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vcluster 0.21 seems to not respect --kubernetes-version
2 participants
@kale-amruta @felipecrs