You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Would it make more sense for scalablyTypedBasePath to default to millSourcePath / os.up instead of T.workspace?
Currently if you use mill-scalablytyped in a sub or foreign module it will look in the root module for the package.json.
However if you are trying to wrap JS libs it will look in the root project which ruins the encapsulation. I defer to you superior JavaScript knowledge in this. I can work around by:
The limiting factor here is that mill doesn't currently allow to run tests in a different wd that T.workspace (see com-lihaoyi/mill#1036).
Maybe after that is fixed we could change the default to millSourcePath, but until that is fixed changing it does more harm than good.
Would it make more sense for
scalablyTypedBasePath
to default tomillSourcePath / os.up
instead ofT.workspace
?Currently if you use
mill-scalablytyped
in a sub or foreign module it will look in the root module for thepackage.json
.However if you are trying to wrap JS libs it will look in the root project which ruins the encapsulation. I defer to you superior JavaScript knowledge in this. I can work around by:
(This is effectively
T.workspace
in a simple project)The text was updated successfully, but these errors were encountered: