Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other sam support #541

Closed
O-O1024 opened this issue Apr 5, 2024 · 3 comments
Closed

Other sam support #541

O-O1024 opened this issue Apr 5, 2024 · 3 comments

Comments

@O-O1024
Copy link

O-O1024 commented Apr 5, 2024

Original sam is too slow, now there are some replacement, eg.
fastsam
mobilesam
EfficientSAM

@ltdrdata
Copy link
Owner

ltdrdata commented Apr 6, 2024

Support for EfficientSAM was added, based on this PR.
ZHO-ZHO-ZHO/ComfyUI-YoloWorld-EfficientSAM#32

To utilize EfficientSAM, you must first install the YoloWorld extension.
And then ESAM feature becomes available after that PR is merged.

@niko2020
Copy link

niko2020 commented Apr 12, 2024

Excuse me I'm not sure I correctly understand. It is now possible to use YOLO-World with Impact Pack?
But it is required to install ZHO-ZHO-ZHO/ComfyUI-YoloWorld-EfficientSAM (which I'm afraid causes problems because of depedencies).

@ltdrdata
Copy link
Owner

ltdrdata commented Apr 15, 2024

Excuse me I'm not sure I correctly understand. It is now possible to use YOLO-World with Impact Pack? But it is required to install ZHO-ZHO-ZHO/ComfyUI-YoloWorld-EfficientSAM (which I'm afraid causes problems because of depedencies).

Yes, to use this, you'll need to install ComfyUI-YoloWorld-EfficientSAM.

Currently, since it's not merged, you can use this instead for immediate use: (my forked version)
https://github.com/ltdrdata/ComfyUI-YoloWorld-EfficientSAM

Test results show that the current dependencies are optimal. If upgraded to even slightly higher versions, it won't be compatible with Python 3.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants