add ssl unit tests #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Structure is not ideal. Instead, provide a library function that generates the certificates, and follow the existing test structure e.g. add a SSL test to https://github.com/m-labs/sipyco/blob/master/sipyco/test/test_pc_rpc.py. For the elements that don't have tests like Broadcaster then add some, with and without SSL. rpctool also needs to be tested with SSL. |
fsagbuya
force-pushed
the
ssl_tests
branch
2 times, most recently
from
794f617 to
200be2e
Compare
sipyco/test/test_broadcast.py
Outdated
| test_message = {"key": "value", "number": 42} | ||
|
|
||
|
|
||
| class BroadcastCase(unittest.TestCase): |
There was a problem hiding this comment.
Split into separate PR as discussed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add SSL unit tests:
sipycoprotocolsRequires:
#46
#47
Closes #48
TODO: add tests for logging and broadcast