Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize handling of peak mappings #109

Open
jlmaccal opened this issue Nov 9, 2021 · 0 comments
Open

Optimize handling of peak mappings #109

jlmaccal opened this issue Nov 9, 2021 · 0 comments
Assignees

Comments

@jlmaccal
Copy link
Contributor

jlmaccal commented Nov 9, 2021

The way we decide which restraints to update based on peak mappings is quite slow. This is expensive during Monte Carlo sampling.

We currently get the value for every single peak mapping and compare it with the previous value. Instead, we should directly compare all of the mappings to compare those that are different. This requires some nasty indexing gymnastics but should be much faster.

@jlmaccal jlmaccal self-assigned this Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant