Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplication of Grouped Products does not work as expected #10679

Open
densen45 opened this issue Aug 28, 2017 · 16 comments · May be fixed by #39533
Open

Duplication of Grouped Products does not work as expected #10679

densen45 opened this issue Aug 28, 2017 · 16 comments · May be fixed by #39533
Assignees
@magentoabu
Labels
Area: Product Component: GroupedProduct Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: ready for dev Reported on 2.3.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@densen45
Copy link
Contributor

densen45 commented Aug 28, 2017 •
edited by sdzhepa
Loading

Preconditions

Magento version 2.1.7
Updated(09/19/2019): Still actual on 2.3-develop

Steps to reproduce

  1. Create a Grouped Product
  2. Add child / associated Simple Products to the Grouped Product
  3. Save the Grouped Product
  4. Duplicate the Grouped Product

Expected Result

The duplicate of the Grouped Product has the same associated Simple Products as the earlier created Grouped Product.

Actual Result

The duplicate of the Grouped Product has no associated Simple Product.

Investigation

On duplication the Magento\GroupedProduct\Model\Product\Type\Grouped::beforeSave function is called. In this function the cache for the associated products is being cleaned:

magento2/app/code/Magento/GroupedProduct/Model/Product/Type/Grouped.php

Line 480 in 24f2f07

$product->unsetData($this->_keyAssociatedProducts);

After removing this line of code, the duplication of Grouped Products works as expected.
@magento-engcom-team magento-engcom-team added Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed and removed G1 Passed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 11, 2017
@okorshenko okorshenko added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 14, 2017
@keyurshah070
Copy link
Contributor

Started Investigating

@crissanclick
Copy link
Contributor

crissanclick commented Oct 8, 2017 •
edited
Loading

Can I work on this issue? thanks

@okorshenko
Copy link
Contributor

Hi @crissanclick could you please accept the invitation on GitHub?

@crissanclick crissanclick mentioned this issue Oct 9, 2017
Closed
4 tasks
@ghost ghost self-assigned this Jul 31, 2018
@ghost ghost added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Component: GroupedProduct Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Aug 1, 2018
@ghost
Copy link

ghost commented Aug 1, 2018

@densen45 , thank you for your report.
We've acknowledged the issue and added to our backlog.

@ghost ghost removed their assignment Aug 1, 2018
@Dharmeshvaja91 Dharmeshvaja91 self-assigned this Oct 23, 2018
@magento-engcom-team
Copy link
Contributor

Hi @Dharmeshvaja91. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@engcom-Bravo engcom-Bravo removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Apr 30, 2024
@engcom-Bravo engcom-Bravo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Progress: ready for dev labels Apr 30, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-11887 is successfully created for this GitHub issue.

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Apr 30, 2024

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@github-jira-sync-bot
Copy link

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-11887

@engcom-Hotel engcom-Hotel moved this to Ready for Development in Low Priority Backlog Aug 19, 2024
@magentoabu magentoabu linked a pull request Jan 10, 2025 that will close this issue
Open
5 tasks
@magentoabu
Copy link

@magento i'm working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magentoabu magentoabu

Labels
Area: Product Component: GroupedProduct Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: ready for dev Reported on 2.3.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

10679 Duplication of Grouped Products does not work as expected issue… magentoabu/magento2