Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements for ComputeProperStatByWindow #466

Open
4 tasks
magicDGS opened this issue Jun 5, 2018 · 0 comments
Open
4 tasks

Enhancements for ComputeProperStatByWindow #466

magicDGS opened this issue Jun 5, 2018 · 0 comments
Labels
Priority: Medium Status: Accepted Accepted in the project backlog Type: Epic Tasks that should be split in different issues

Comments

@magicDGS
Copy link
Owner

magicDGS commented Jun 5, 2018

  • Create abstract engine class to support other enhancements, and construct with a builder
  • Support unsorted files - the engine in this case should hold all the windows without flushing until the traversal is finished. This have a performance cost, but it will be useful to analyze raw mapped data before sorting.
  • Add support for sliding-window analyses - I believe that the current implementation supports this traversal, but depends on how the engine is optimized (Evaluate performance improvements for ProperStatWindowEngine #458) if this will continue working.
  • Remove no-interval parameters requirement. This depends on GATK making accessible the intervals for traversal (to make the windows) and GATK making a public method to change intervals for traversal within reads (before starting traversal). Another option is to implement a pair-end walker using something like TwoPassReadWalker: allow different ways for traversal in each pass broadinstitute/gatk#4849
@magicDGS magicDGS added Priority: Medium Status: Accepted Accepted in the project backlog Type: Epic Tasks that should be split in different issues labels Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Status: Accepted Accepted in the project backlog Type: Epic Tasks that should be split in different issues
Projects
None yet
Development

No branches or pull requests

1 participant