Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate events caused by large adjustments to event times during reassignment #10

Open
tjd2002 opened this issue Feb 22, 2019 · 0 comments

Comments

@tjd2002
Copy link
Contributor

tjd2002 commented Feb 22, 2019

@hrjoo and I discovered that we only saw duplicate events on channels there had been a reassignment of events (to that channel) with a large delta_t (typically -18 samples, larger than the detect_interval of 10). We suspect that such large time adjustments are incorrect. Probably there needs to be some dependency on detect_interval in or near this line:

dt=tc_peak_times[assigned_channel_within_neighborhood][k]-tc_peak_times[m_central_rel][k]

NB: we still see duplicate events in ml_ms4alg v.0.2.1 (with the per-neighborhood duplicate event deletion provided by 0a8e350). This is probably because that fix does not address duplication across neighborhoods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant