Updates to import-to-bn.py

[as0ni]

Description

The import-to-bn.py script does not support capa's current JSON output schema. This issue proposes several updates to improve compatibility.

Happy to implement if these updates look good.

Proposed Changes

Current (1)

else:
    path = binaryninja.interaction.get_open_filename_input("capa report:", "JSON (*.js *.json);;All Files (*)")

Update (1)

Convert the string returned by get_open_filename_input() to a Path object for compatibility with Path methods:

else:
    path = binaryninja.interaction.get_open_filename_input("capa report:", "JSON (*.js *.json);;All Files (*)")
    path = Path(path)

Current (2)

if rule["meta"]["scope"] != "function":
    continue

Update (2)

Align with the latest capa JSON schema:

if rule["meta"]["scopes"]["static"] != "function":
    continue

Current (3)

for va in rule["matches"].keys():
    va = int(va)
    rows.append((ns, name, va))

Update (3)

Align with the latest capa JSON schema:

for match in rule["matches"]:
    va = int(match[0]["value"])
    rows.append((ns, name, va))

Versions

Tested by producing JSON output with capa v8.0.1 and running updated import-to-bn.py using Binary Ninja 4.2.6455.

[williballenthin]

Great catches! Thanks for noticing and reporting the issues.

All your proposed solutions look good. We'd be happy to merge those in if you'll contribute them.

Thanks @as0ni!