New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape to Close Combobox does not work on Safari #7337

Closed

1 of 2 tasks

elibroftw opened this issue Jan 7, 2025 · 1 comment · Fixed by #7358

Closed

1 of 2 tasks

Escape to Close Combobox does not work on Safari #7337

elibroftw opened this issue Jan 7, 2025 · 1 comment · Fixed by #7358

Labels

Fixed

elibroftw commented Jan 7, 2025

Dependencies check up

I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

7.15.1

What package has an issue?

@mantine/core

What framework do you use?

Vite

In which browsers you can reproduce the issue?

Safari

Describe the bug

In Firefox, when I open a combobox I can close it using Escape. But on Safari, this is not true.

If possible, include a link to a codesandbox with a minimal reproduction

https://mantine.dev/core/combobox/

Possible fix

https://stackoverflow.com/questions/719537/capture-an-escape-keypress-in-webkit-browsers

Self-service

I would be willing to implement a fix for this issue

Author

elibroftw commented Jan 7, 2025

Note that Modal works as intended.

yuki0410-dev mentioned this issue

[@mantine/core] Fix On Escape KeyDown handling to Combobox component #7358

Merged

rtivital closed this as completed in #7358

rtivital added the Fixed label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment