Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rendering description as Markdown. #6

Open
louh opened this issue Jun 28, 2017 · 0 comments
Open

Allow rendering description as Markdown. #6

louh opened this issue Jun 28, 2017 · 0 comments

Comments

@louh
Copy link
Contributor

louh commented Jun 28, 2017

The info button implementation (#1) only allows for plain text -- this is because raw HTML (as requested originally) poses a security risk. It would be possible for someone to write a scene with malicious code saved in the description, and then send it to someone where the injected code could hijack that person's credentials and take over their Mapzen account.

It is safer to render the content via Markdown so that the person who provides the description can still add links, bold or italicized text, paragraphs, and more. As a result, the description render should make use of a Markdown rendering library to run description text through. (CommonMark spec is preferred.)

Along with this, there should be instructions in Tangram Play for Markdown syntax.

cc @burritojustice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant