Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use useAttributeAsKey('name') in Configuration #5

Open
ivoba opened this issue Nov 28, 2014 · 1 comment
Open

Use useAttributeAsKey('name') in Configuration #5

ivoba opened this issue Nov 28, 2014 · 1 comment

Comments

@ivoba
Copy link

ivoba commented Nov 28, 2014

I guess the name config can be ommited when the key is used as name with useAttributeAsKey in Configuration.php.
As this config is in the most cases a repition, right?

my_feature:
    name: my_feature

I can provide a PR if you aggree, however this would mean a BC break.

@marekkalnik
Copy link
Owner

Hi @ivoba,

thanks for taking the time to report this. I agree with you, but I don't maintain this bundle anymore. If you want to take it over, feel free to fork it and I will put a redirect to your fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants