-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can you make a higher resolution photo? #1
Comments
Which resolution are you thinking of? |
2 times larger, because the photo looks blurry |
If it's blurry then it might be that it's not grid aligned. Please have a look at this issue: material-extensions/vscode-material-icon-theme#2225. The intention of this image is to give a preview how the icon could look like in a file icon theme as it is used for the Material Icon Theme. I've also adjusted it already in the past to make it more similar to the rendering of VS Code (see 81ebc42). In addition the image is not provided in super high resolution from the image provider itself, but for the preview it's fine for me. And if the bigger image should be 2 times larger it might look odd if there're multiple icons in a list, as it is shown here: |
Got it, thanks |
@PKief, In icon-review there is already a link to a preview of the pixel-perfect icon, and I believe that there is no point in making a blurry image |
@okineadev the idea is to give a preview how does the icon looks in the file explorer of VS Code. It's intentionally that the icon is very small. It demonstrates how the icon looks in very small. If some icons don't look good in a very small size, then it's an indicator that we need to improve that icon. All icons need to be in a good shape to be visible also in small sizes. |
Is it possible to make the image clearer in general, but the small icons will be blurred as they are now? |
We have to figure it out. Probably it's due to the image service we are using for it. It sends the image with a lower quality. If you like you can try to find another image service - which is free to use and provides an API which we can call from a GitHub workflow. I'm quite busy at the moment, and can live with the current quality of the preview image. As you've said, for getting a better quality image you can click on the pixel perfect link or open the file directly in either GitHub or in VS Code. |
Okay |
Closed with #4 |
It would be nice if you could take a clearer photo
The text was updated successfully, but these errors were encountered: