Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you make a higher resolution photo? #1

Closed
okineadev opened this issue May 23, 2024 · 11 comments · Fixed by #4
Closed

Can you make a higher resolution photo? #1

okineadev opened this issue May 23, 2024 · 11 comments · Fixed by #4

Comments

@okineadev
Copy link
Member

It would be nice if you could take a clearer photo

@PKief
Copy link
Member

PKief commented May 23, 2024

Which resolution are you thinking of?

@okineadev
Copy link
Member Author

2 times larger, because the photo looks blurry

@PKief
Copy link
Member

PKief commented May 23, 2024

If it's blurry then it might be that it's not grid aligned. Please have a look at this issue: material-extensions/vscode-material-icon-theme#2225. The intention of this image is to give a preview how the icon could look like in a file icon theme as it is used for the Material Icon Theme. I've also adjusted it already in the past to make it more similar to the rendering of VS Code (see 81ebc42). In addition the image is not provided in super high resolution from the image provider itself, but for the preview it's fine for me. And if the bigger image should be 2 times larger it might look odd if there're multiple icons in a list, as it is shown here:

image

@okineadev
Copy link
Member Author

Got it, thanks

@okineadev
Copy link
Member Author

@PKief, In icon-review there is already a link to a preview of the pixel-perfect icon, and I believe that there is no point in making a blurry image

@okineadev okineadev reopened this Jul 16, 2024
@PKief
Copy link
Member

PKief commented Jul 16, 2024

@okineadev the idea is to give a preview how does the icon looks in the file explorer of VS Code. It's intentionally that the icon is very small. It demonstrates how the icon looks in very small. If some icons don't look good in a very small size, then it's an indicator that we need to improve that icon. All icons need to be in a good shape to be visible also in small sizes.

@okineadev
Copy link
Member Author

Is it possible to make the image clearer in general, but the small icons will be blurred as they are now?

@PKief
Copy link
Member

PKief commented Jul 16, 2024

We have to figure it out. Probably it's due to the image service we are using for it. It sends the image with a lower quality. If you like you can try to find another image service - which is free to use and provides an API which we can call from a GitHub workflow.

I'm quite busy at the moment, and can live with the current quality of the preview image. As you've said, for getting a better quality image you can click on the pixel perfect link or open the file directly in either GitHub or in VS Code.

@okineadev
Copy link
Member Author

Okay

@okineadev
Copy link
Member Author

I experimented with this tool and this is what I got:

image

A small image is specially blurred to understand whether it will look good in the editor

@PKief
Copy link
Member

PKief commented Jul 22, 2024

Closed with #4

@PKief PKief closed this as completed Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants