Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in EIP721Base domain separator implementation #84

Open
ivandiazwm opened this issue Jun 28, 2021 · 0 comments
Open

Typo in EIP721Base domain separator implementation #84

ivandiazwm opened this issue Jun 28, 2021 · 0 comments

Comments

@ivandiazwm
Copy link

ivandiazwm commented Jun 28, 2021 •
edited
Loading

It looks like there's a typo in EIP712Base implementation. It called getDomainSeperator but it should be getDomainSeparator
https://github.com/maticnetwork/pos-portal/blob/master/contracts/common/EIP712Base.sol#L46
It looks like this issue is repeated in variables and other functions.

I can open a PR but I'm not sure if it's ok since it would change the contract's interface.
DAI proxy's implementation contract depends on this getDomainSeperator function and it's deployed with the typo.
@ivandiazwm ivandiazwm changed the title Typo on EIP721Base domain separator implementation Typo in EIP721Base domain separator implementation Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ivandiazwm