Fix failing room state endpoints (setting state twice)

[kegsay]

Sytests:

    × Setting state twice is idempotent

[MadLittleMods]

Looks related to #1311

[piyushsingariya]

Is this issue still open? Can I have a look over this?

[MadLittleMods]

Go for it @piyushsingariya!

[piyushsingariya]

@MadLittleMods Can you explain to me a bit about this issue? as I am new and having a hard time understanding Dendrite's issues and its codebase. It would be helpful if you could guide me.
Thanks in advance :)

[MadLittleMods]

@piyushsingariya I am also very new and struggling my way through a good first issue as well with #1671.

To start, add Setting state twice is idempotent to sytest-whitelist.

Then run Sytest (see https://github.com/matrix-org/dendrite/blob/master/docs/sytest.md for how to run) and see what fails (your test is in tests/30rooms/01state.pl)

[keremgocen]

hey @piyushsingariya were you able to progress on this one? I can try to help if you need any or I'm also happy to take a look myself, looking for a #good-first-issue to get myself familiarised with this dendrite.

[piyushsingariya]

yeah go ahead @keremgocen , I'm not focusing on this.

[keremgocen]

I'm looking at this and left a comment here. It's not obvious to me what should be the fix;

• should I look at https://github.com/matrix-org/dendrite/blob/master/clientapi/routing/joinroom.go and check if the user is already joined somehow
• or it's about the event being returned and the new event returned must have a different id here https://github.com/matrix-org/dendrite/blob/master/clientapi/routing/sendevent.go

Not sure how the 2nd event ends up having the same id, when I look at the failing test code here: https://github.com/matrix-org/sytest/blob/master/tests/30rooms/01state.pl#L287

Any guidance would be helpful as this is my first issue, thanks.

[Tert0]

I get

Test 137 Setting state twice is idempotent... EXPECTED FAIL

as output for SyTests.

Does that mean that it works?

[kegsay]

No, you need it to be ... OK

[ParthGala2k]

Hello, I plan to apply to matrix for the dendrite project as part of GSoC this year and was looking to familiarise myself with the codebase.
If no one is looking at this issue, is it okay if I have a go at it ?

[kegsay]

Still failing as of today: 2022-05-20T11:38:39.9370342Z ❌ Setting state twice is idempotent

[S7evinK]

Fixed in #2512