Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mentions of m.login.token linger in the spec #3733

Closed
ShadowJonathan opened this issue Feb 18, 2022 · 5 comments
Closed

Mentions of m.login.token linger in the spec #3733

ShadowJonathan opened this issue Feb 18, 2022 · 5 comments
Labels
spec-bug Something which is in the spec, but is wrong

Comments

@ShadowJonathan
Copy link
Contributor

ShadowJonathan commented Feb 18, 2022 •
edited
Loading

Link to problem area: https://spec.matrix.org/v1.2/client-server-api/, search for m.login.token

Issue
As per #2611, these references should've been removed.

Related: https://github.com/matrix-org/matrix-doc/issues/3732
@ShadowJonathan ShadowJonathan added the spec-bug Something which is in the spec, but is wrong label Feb 18, 2022
@richvdh
Copy link
Member

richvdh commented Feb 18, 2022

the references look correct to me?

@ShadowJonathan
Copy link
Contributor Author

A bit in client-server -> Login seems to very explicitly describe or specify some aspects of m.login.token, shouldn't those have been removed as per #2611?

@turt2live
Copy link
Member

The UIA type was removed but not the login type.

@ShadowJonathan
Copy link
Contributor Author

Then that clarifies things a little, thanks.

@ShadowJonathan ShadowJonathan mentioned this issue Feb 18, 2022
Closed
@richvdh
Copy link
Member

richvdh commented Feb 21, 2022

The text of MSC2611 explicitly says:

For clarity: this proposal does not suggest making any changes to the m.login.token login type.

It feels like a little more attention could have saved a bunch of people some time here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec-bug Something which is in the spec, but is wrong
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@turt2live @richvdh @ShadowJonathan