<address>.call{value: value}(new bytes(0)) causes ERROR call may fail or behave unexpectedly due to empty code

[vmaark]

Component

Forge

Have you ensured that all of these are up to date?

• Foundry
• Foundryup

What version of Foundry are you on?

forge 0.0.2 (68fcb7d 2024-12-16T00:45:46.210537000Z)

What command(s) is the bug in?

forge test

Operating System

macOS (Apple Silicon)

Describe the bug

Sending eth with .call causes the following log in my forge test output:
2024-12-18T22:55:36.093440Z ERROR foundry_zksync_core::vm::tracers::cheatcode: call may fail or behave unexpectedly due to empty code target=0x0000000000000000000000000000000000989682 calldata=""

Although it displays it as an ERROR, the execution continues. Due to having a lot of tests and fuzzing, this really pollutes my console.

Proposed solution:
When calldata is empty, due not assume it's a function call, don't check the address for code.

[vmaark]

Also I suspect that this is making somehow my tests running extremely slow (30 minutes on github actions, instead of like 5 mins), not sure if there's some retry mechanism under the hood, or it's just the fuzzing, but I have 100s of lines of the same error being reported (and ignored, execution continues).

[Jrigada]

Hey @vmaark can you share an example of a test that is printing the error? A simple

.call{value: value}("") is not printing it out for me.

contract A {
    receive() external payable {}
}

contract AddressCallTest is Test {
    A internal a;
    function setUp() public {
        a = new A();
    }
    function testAddressCall() public {
        (bool success, ) = address(a).call("");
        assertTrue(success);
    }

    function testAddressCallValue() public {
        (bool success, ) = address(a).call{value: 1 ether}("");
        assertTrue(success);
        assertEq(address(a).balance, 1 ether);
    }
}

From what I've seen it depends on how and where you do the deployment of the contract you are then calling.

[vmaark]

contract A {
receive() external payable {}
}

contract AddressCallTest is Test {
A internal a;
function setUp() public {
a = new A();
}
function testAddressCall() public {
(bool success, ) = address(a).call("");
assertTrue(success);
}

function testAddressCallValue() public {
    (bool success, ) = address(a).call{value: 1 ether}("");
    assertTrue(success);
    assertEq(address(a).balance, 1 ether);
}

}

in this example you're sending to a contract which works fine. It happens when sending eth to an EOA using .call - sorry if that wasn't clear from the original description.

Also additionally this ERROR / warning is making the test run extremely slow.

[Jrigada]

Hey @vmaark we just merged a fix for this exact case. It should spare you from the error you were getting. Thanks for raising it.

[vmaark]

hey @Jrigada, thanks for the quick fix, sounds great! Updated zksync-forge, I assume it is not yet included in the following version:

✗ forge --version
forge 0.0.2 (04e701d 2025-01-09T00:34:37.572492000Z)

[Jrigada]

Yes, is not present yet in the release. To use it right now you would have to build directly from main. Probably by today or early next week it will be on the new release!