Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate support for custom CREATE2 deployer #830

Open
elfedy opened this issue Jan 9, 2025 · 0 comments
Open

Evaluate support for custom CREATE2 deployer #830

elfedy opened this issue Jan 9, 2025 · 0 comments
Labels
feature ➕ Feature item Internal ⚙️ needs triage ♟️ Issue needs to be picked up or assigned upstream-parity 🟰 Needed for upstream feature parity

Comments

@elfedy
Copy link
Contributor

elfedy commented Jan 9, 2025

Component

Forge

Describe the feature you would like

https://github.com/foundry-rs/foundry/pull/9278/files adds support for specifying a CREATE2 deployer with an address that's not the default. When that is done, it is checked that its code hash matches the code hash of the default CREATE2 deployer source code. On ZKsync, we are still checking CREATE2 deployer address, so support for a custom CREATE2 deployer address needs to be evaluated and, if deemed valuable, implemented.

Additional context

No response
@elfedy elfedy added feature ➕ Feature item needs triage ♟️ Issue needs to be picked up or assigned labels Jan 9, 2025
@Jrigada Jrigada added Internal ⚙️ upstream-parity 🟰 Needed for upstream feature parity labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature ➕ Feature item Internal ⚙️ needs triage ♟️ Issue needs to be picked up or assigned upstream-parity 🟰 Needed for upstream feature parity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elfedy @Jrigada