Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Currency Conversion Issue in Budget Calculation #1653

Open
rezaplus opened this issue Jan 22, 2025 · 4 comments
Open

Bug: Currency Conversion Issue in Budget Calculation #1653

rezaplus opened this issue Jan 22, 2025 · 4 comments
Labels
1️⃣ High Priority High priority issues will be worked on next

Comments

@rezaplus
Copy link

Bug Description:
There is a discrepancy between the transaction currency and the budget calculation currency. Specifically, as seen in the attached screenshot:

Transactions are recorded in TRY (Turkish Lira).
Budgets are calculated using the default currency (USD), without proper currency conversion.

This leads to misleading budget overspending values. For example:

Transaction: 13,000 TRY (correctly recorded).
Budget: 365 USD, leading to an inaccurate overspending calculation of $12,635 USD.

Image

@rezaplus rezaplus changed the title Bug: Bug: Currency Conversion Issue in Budget Calculation Jan 22, 2025
@zachgoll
Copy link
Collaborator

@rezaplus thanks for the report! Just to confirm—is your family currency set to USD, and a subset of your accounts have transactions in TRY?

In other words, you're intending for the overall budget to be in USD and specifically commenting on how individual transactions are not properly rolled into the totals?

@rezaplus
Copy link
Author

Hi @zachgoll thanks for getting back to me!

Yes, my family currency is set to USD, but I have accounts with transactions in TRY.

I intend for the overall budget to remain in USD, but the issue is that individual transactions in TRY are not being properly converted into USD before being rolled into the totals. This causes the budget calculations to show inaccurate values and overspending warnings.

Let me know if you need more details or testing on my end!

@zachgoll
Copy link
Collaborator

@rezaplus got it, thanks for the detail! That's all I need.

@zachgoll zachgoll added the 1️⃣ High Priority High priority issues will be worked on next label Jan 23, 2025
@zachgoll
Copy link
Collaborator

We may need to implement #1615 prior to being able to fix this because many of the budget calculations are run in fairly verbose queries, which will require joins on the exchange_rates table (and thus, will need those rates pre-loaded).

@zachgoll zachgoll removed the 🐛 Bug label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1️⃣ High Priority High priority issues will be worked on next
Projects
None yet
Development

No branches or pull requests

2 participants